fix: validate action parameter and correct database health check logic

- Add whitelist of valid actions to prevent arbitrary action values
- Fix error handling to properly detect database failures

Previously, any action value was accepted without validation, which could lead to unexpected behavior. The health check also incorrectly set dbOK to true when queries succeeded, now correctly sets it to false when errors occur.

.github/workflows/ci-cd.yml

@@ -4,7 +4,7 @@ on:
   push:
     branches: [main, master]
     paths: 
-      - 'src/'
+      - 'src/**'
   pull_request:
     branches: [main, master]
 
@@ -22,6 +22,9 @@ jobs:
       - name: Download dependencies
         run: /usr/local/go/bin/go mod download
 
+      - name: Tidy modules
+        run: /usr/local/go/bin/go mod tidy
+
       - name: Check formatting
         run: |
           if [ "$(/usr/local/go/bin/gofmt -l $(find . -name '*.go' -not -path './vendor/*'))" ]; then

.gitignore

@@ -1,2 +1,3 @@
 *.exe
 *.env
+*.db*

src/auth.go

@@ -243,9 +243,16 @@ func parseLogFilter(r *http.Request) (*logFilter, error) {
 		Offset: 0,
 	}
 
+	validActions := map[string]bool{
+		"add_temp": true, "delete_temp": true,
+		"add_perm": true, "delete_perm": true, "expire_temp": true,
+	}
+
 	if v := r.URL.Query().Get("action"); v != "" {
+		if validActions[v] {
 			f.Action = v
 		}
+	}
 	if v := r.URL.Query().Get("ip"); v != "" {
 		f.IP = v
 	}
@@ -302,8 +309,8 @@ func logsHandler(db *sql.DB) http.HandlerFunc {
 		logs := make([]map[string]interface{}, 0)
 		for rows.Next() {
 			var ts time.Time
-			var action, apiClientIP string
+			var action string
-			var ip, reason sql.NullString
+			var ip, reason, apiClientIP sql.NullString
 			var ttlSeconds sql.NullInt64
 			if err := rows.Scan(&ts, &action, &ip, &ttlSeconds, &reason, &apiClientIP); err != nil {
 				continue
@@ -311,7 +318,7 @@ func logsHandler(db *sql.DB) http.HandlerFunc {
 			entry := map[string]interface{}{
 				"timestamp":     ts,
 				"action":        action,
-				"api_client_ip": apiClientIP,
+				"api_client_ip": apiClientIP.String,
 				"reason":        reason.String,
 			}
 			if ip.Valid {
@@ -333,13 +340,13 @@ func statusHandler(db *sql.DB) http.HandlerFunc {
 	return func(w http.ResponseWriter, r *http.Request) {
 		var permCount int
 		var tempCount int
-		dbOK := false
+		dbOK := true
 
-		if err := db.QueryRow(`SELECT COUNT(*) FROM perm_whitelist`).Scan(&permCount); err == nil {
+		if err := db.QueryRow(`SELECT COUNT(*) FROM perm_whitelist`).Scan(&permCount); err != nil {
-			dbOK = true
+			dbOK = false
 		}
-		if err := db.QueryRow(`SELECT COUNT(*) FROM temp_whitelist WHERE expires_at > ?`, time.Now().Format(time.RFC3339)).Scan(&tempCount); err == nil {
+		if err := db.QueryRow(`SELECT COUNT(*) FROM temp_whitelist WHERE expires_at > ?`, time.Now().Format(time.RFC3339)).Scan(&tempCount); err != nil {
-			dbOK = true
+			dbOK = false
 		}
 
 		health := map[string]interface{}{